Edit Menu Clean Up

Document In Development

Please use the discussion wiki page for feedback about this document.

Contents

Introduction

Songbird's edit menu is limp.

Purpose of This Document

This document is a proposed solution for 2116.

Goals

By user


Wireframes

Teh edit menu

menu.png

Mock up of find UI on top

find-on-top.png

Specification

Description

ID Cost Title Story
[1] 1

Hook up Firefox's edit menu

The edit menu behaves identical to that of Firefox when the main content pane is displaying a webpage. The menu should behave the same as Firefox for all text fields and text areas - wherever they may be in the UI.

[2] 3

Hook up Firefox's Find function in webpages

Note: Can we prototype this and see where the find bar fits best/easiest?

[3] 3

Copying rows in media lists = tab-delimited-cell-values

If the user selects one or more rows and selects Copy then a tab-delimited string of cell values should be copied to the clipboard.

[4] 0

Disable Cut and Paste for media view

What the summary says.

[5] 0

Delete in media list context deletes the media item(s)

If the user selects one or more rows and selects Delete then a the selected media items are removed from the list.

[6] 0

Select All selects all rows in media view

What the summary says.

SKIP

Hook up Find and Find Again to non-webpage-pages

The user is able to use Find functionality on media views in the same way as in webapages.

The Find and Find Again menus should be disabled

[7] 1

Skin find bar to match feather

We have no spec for how the find bar should look - let's see what we get for free and reserve some time during cleanup to fix up the CSS.

Engineering Notes

Basic Edit Menu Support

The basic edit functions are all handled by toolkit. Issuing goDoCommand('cmd_undo') will correctly route undo to the focused element.

Web Find Bar

This task will consist mostly of porting some code from Firefox, adding styles, and verifying that everything works correctly.

See:

Note that placing the findbar between the web playlist and the page means having a find bar per tab. This differs from mozilla's usage, which is to reuse one findbar for all tabs. We may want to consider placing the findbar at the top of the web page in order to avoid this issue.

We'll probably need at least a day of VisDe review.

Playlist Widget Edit Commands

Adding custom command handling to the playlist widget should only require implementing a command controller. All the playlist edit options may be fixable with a single task.

See http://lxr.mozilla.org/seamonkey/source/browser/components/places/content/controller.js#97 for an example.

Production Notes

Asset list
  • Find bar buttons/gradient?
Visual design
  • Find bar location and appearance

Additional Engineering Notes

  • There are some platform-specific differences in the menu - eg: "Special Characters..." on Mac OS
  • Shortcut keys for the menu vary by platform

Known Risks

  • Select all in the playlist widget has caused us problems in the past. The browser treats it as a web page and tries to select all the content rather than routing the command to the playlist tree. I wouldn't be shocked if we run into bugs here.

Interdependencies

Future

Reference

Firefox 3's New Find Hat

firefox-3-find.png

Firefox Edit Menus By Platform

Linux

ubuntu-edit-menu.jpg

Mac OS

mac-os-edit-menu.png

(On Mac OS, the [backspace] or [delete] key both invoke delete)

Windows

widnows-edit-menu.png

Notes

Komi 19:16, 3 March 2008 (PST) Seeding document

Komi 00:10, 4 March 2008 (PST) Daniel posted some notes/questions and I answered them

Komi 17:03, 4 March 2008 (PST) Reviewed doc with Matt and Mark. We should have a rough estimate by the end of the week.

Matt 15:08, 6 March 2008 (PST) Added engineering notes, preliminary costs, and asset/design requirements.

Komi 13:54, 18 March 2008 (PDT) Reviewed doc with John and Nick

Comments from Daniel

  • In ID#4 should Delete toss a dialog box asking the user if they want to delete the media item from the library, noting that it will remain on their comter?
    • komi Songbird does not manage media files - Songbird doesn't need to display this dialog because it only deletes media from its DB.
  • When would Undo & Redo be used? When is it enabled/disabled? Is it just in metadata editing or other places too?
    • komi Firefox gives us undo/redo for text editing for free, maybe. I'll as engineering.
  • In ID#3 why shouldn't cut/paste work if a user is editing a field?
    • komi We get the edit menu for text fields for free because Firefox has it. I am pointing out any differences.
  • In ID#6 how does "find" highlight the found text in rubber ducky (on both a dark/light row)? What exactly is highlighted, the field, the word/phrase, the row? I'm not so sure about this one...I think search should do the trick until we have media pages/views that get kinda crazy and people start asking for it, what do you think?
    • komi I think it would be useful (I would use it, for sure). I'll get it costed anyway and we talk talk afterwards.
      • komi removed because we kinda have the behavior already
  • What are the key commands for each of these menu items (and for each platform)?
    • komi We get this for free from Firefox, maybe. We don't want to deviate here.
  • Should 'Delete' be Clear on any of the platforms?
    • komi We get platform-specific text labels for free too, maybe. With Firefox, all platforms read "Delete".

Tag page
You must login to post a comment.